Repository navigation
chore(deps): refresh HTTP and ZIP dependencies - #1015
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesUpdates ureq to 3.5.2 and zip to 9.5.1 with their required transitive dependencies and a changelog entry. Example: OCM extracts the managed Node.js 24.22.1 Windows distribution.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review This PR provides a useful dependency refresh that is absent from main; no actionable defect was found, and the Linux and macOS test jobs remain in progress. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherOCM's shared download and archive helpers consume HTTP responses and downloaded archives, producing metadata, verified artifact files, and extracted toolchains. flowchart LR
A[Runtime or toolchain setup] --> B[Shared HTTP client]
B --> C[Downloaded artifact]
C --> D[Checksum verification]
D --> E[ZIP extraction]
E --> F[Staged toolchain]
Technical reviewBest possible solution: Land the scoped dependency refresh once the existing required platform checks pass. Do we have a high-confidence way to reproduce the issue? This maintenance PR establishes no failing OCM reproduction; review inspected the dependency changes and existing coverage without running target code. Is this the best way to solve the issue? The lockfile refresh fits the existing version constraints and maintenance direction without adding another implementation or changing OCM configuration. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 96b10323bd10. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 20, 2026, 10:55 PM ET / November 21, 2026, 03:55 UTC. |
What Problem This Solves
OCM's locked HTTP and ZIP dependencies miss current maintenance fixes. The HTTP patch fixes decoded response-size limits, exact-limit bodies, and fallback to another address after a NetworkDown error.
User Impact
Downloads receive those upstream HTTP fixes. ZIP handling moves to the current compatible minor release. Rust 1.88 support, the selected TLS roots, disabled default features, and OCM 0.3.9 stay unchanged.
Why This Change Was Made
Combines Dependabot #1012 (ureq 3.5.2) and #1013 (zip 9.5.1), including only the required transitive lockfile changes. No upgrade lifecycle or migration behavior changes.
Evidence
The complete Rust suite passed 2,069 tests on a disposable Linux worker using Node 24.22.1 and npm 11.19.1. Formatting, all-target compilation, 41 automatic-release policy tests, and five native-Gateway structural tests passed in the prescribed order. The installed binary and Rust 1.88 minimum check are covered by the same worker's final baseline. Independent P0–P2 review was clean.
The initial highly parallel library run encountered a transient ETXTBSY while executing a newly written fake service-manager script (601 passed, one failed). That exact test then passed five isolated runs; the complete suite passed with RUST_TEST_THREADS=2. No test assertion or product code was changed to obtain that result.
PR CI supplies the additional native macOS, Windows, and npm platform coverage. No real OCM/OpenClaw environment was stopped or modified.